Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the tab navigation of the editor #4206

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

reiterl
Copy link
Member

@reiterl reiterl commented Oct 2, 2024

Resolve #4150

Exclude:

  • menu buttons, because here we would need some more logic (ArrowUp,ArrowDown?)

Include: The change of the tabindex at arrow navigation.

@reiterl reiterl added low good first issue enhancement General enhancement which is neither bug nor feature accessibility labels Oct 2, 2024
@reiterl reiterl added this to the 4.2 milestone Oct 2, 2024
@reiterl
Copy link
Member Author

reiterl commented Oct 9, 2024

I talked to @bastianjoel . The implementation is not complete and should be improved using Attribute-Directives.

@reiterl reiterl assigned bastianjoel and unassigned reiterl Oct 28, 2024
@reiterl
Copy link
Member Author

reiterl commented Oct 28, 2024

I don't think the usage of attribute directives is a large improvement here. @bastianjoel can you look at it? Do you have ideas, how to improve it? I tried to get rid of the #btn and the buttonList.

@bastianjoel
Copy link
Member

I don't think this is much better than before either. I will have a look at this when there is time.

@Elblinator Elblinator modified the milestones: 4.2, 4.3 Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility enhancement General enhancement which is neither bug nor feature good first issue low
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve editor controls tab navigation
3 participants