Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to set PoO for others #3324

Merged
merged 13 commits into from
Feb 22, 2024
Merged

Allow to set PoO for others #3324

merged 13 commits into from
Feb 22, 2024

Conversation

Elblinator
Copy link
Member

@Elblinator Elblinator commented Feb 20, 2024 •
edited
Loading

@Elblinator Elblinator added this to the 4.2 milestone Feb 20, 2024
@Elblinator Elblinator self-assigned this Feb 20, 2024
@Elblinator Elblinator assigned bastianjoel and MSoeb and unassigned Elblinator Feb 21, 2024
@Elblinator Elblinator marked this pull request as ready for review February 21, 2024 14:53
@bastianjoel bastianjoel requested review from luisa-beerboom and removed request for bastianjoel February 21, 2024 15:12
@bastianjoel bastianjoel requested review from jsangmeister and removed request for luisa-beerboom February 21, 2024 15:12
jsangmeister
jsangmeister requested changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@jsangmeister jsangmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also update the meta repo & the default setting values

...f-speakers-content/components/list-of-speakers-content/list-of-speakers-content.component.ts Outdated Show resolved Hide resolved
.../pages/meetings/services/meeting-settings-definition.service/meeting-settings-definitions.ts Outdated Show resolved Hide resolved
@Elblinator Elblinator removed their assignment Feb 22, 2024
rrenkert
rrenkert requested changes Feb 22, 2024
View reviewed changes
Copy link
Member

@rrenkert rrenkert left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The user shown in the LoS is always the currently logged in user, not the the selected one.
After added one user (that is the currently logged in user) you can only withdraw the PoO and not add another one.

@rrenkert rrenkert self-requested a review February 22, 2024 10:55
@rrenkert rrenkert merged commit 8725bb8 into OpenSlides:main Feb 22, 2024
3 checks passed
@Elblinator Elblinator deleted the 3314-set-poo-for-others branch March 15, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsangmeister jsangmeister jsangmeister approved these changes

@rrenkert rrenkert rrenkert approved these changes

@MSoeb MSoeb Awaiting requested review from MSoeb

Assignees

@rrenkert rrenkert

@MSoeb MSoeb

Labels
feature high los-extension
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Allow to set point of orders for other users
6 participants
@Elblinator @rrenkert @jsangmeister @bastianjoel @luisa-beerboom @MSoeb