Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve editor controls tab navigation #4150

Open
bastianjoel opened this issue Sep 18, 2024 · 4 comments · May be fixed by #4206
Open

Improve editor controls tab navigation #4150

bastianjoel opened this issue Sep 18, 2024 · 4 comments · May be fixed by #4206
Assignees
@reiterl
Labels
accessibility enhancement General enhancement which is neither bug nor feature good first issue low
Milestone
4.3

Comments

@bastianjoel
Copy link
Member

Currently when navigation with <tab> through a form with an os-editor one has to navigate over all format control buttons.

Wanted behavior
When navigation with tab only the first format control should be focused. When hitting tab again the editors content should be focused.
The other format buttons should still be reachable by using the keyboards arrow keys.
@bastianjoel bastianjoel added good first issue enhancement General enhancement which is neither bug nor feature accessibility labels Sep 18, 2024
@bastianjoel bastianjoel added this to the 4.2 milestone Sep 18, 2024
@reiterl reiterl changed the title Imporve editor controls tab navigation Improve editor controls tab navigation Sep 23, 2024
@rrenkert rrenkert added the low label Sep 24, 2024
@reiterl
Copy link
Member

reiterl commented Sep 26, 2024

I can include a tabindex="-1" for all elements in the os-editor. That should fix the tab navigation.

The other format buttons should still be reachable by using the keyboards arrow keys.
How should that work? Should there be a special keydown handler, which switchs the focus?

@bastianjoel
Copy link
Member Author

bastianjoel commented Sep 26, 2024 •
edited
Loading

I can include a tabindex="-1" for all elements in the os-editor. That should fix the tab navigation.

Stick to the specification I provided. Just setting all Elements to tabindex="-1" would not be sufficient to implement what I asked for.

@reiterl
Copy link
Member

reiterl commented Sep 30, 2024

The problem with the arrow keys: Should that be solved with a kind of js event handler?

@reiterl reiterl self-assigned this Oct 2, 2024
@reiterl
Copy link
Member

reiterl commented Oct 2, 2024

Yes, it should work with a handler and the tabindex should be set to 0 for focused buttons.

@reiterl reiterl linked a pull request Oct 2, 2024 that will close this issue
Open
@rrenkert rrenkert modified the milestones: 4.2, 4.3 Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reiterl reiterl

Labels
accessibility enhancement General enhancement which is neither bug nor feature good first issue low
Projects
None yet
Milestone
4.3
Development

Successfully merging a pull request may close this issue.

Update to the tab navigation of the editor reiterl/openslides-client
3 participants
@bastianjoel @rrenkert @reiterl