-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update meta repository (main) #968
Conversation
@luisa-beerboom Is there anything I have to do in the autoupdate-service? Does the restrictor has to change, when the flag is set, or is it only for writing? |
See client issue OpenSlides/openslides-client#3622 for context Generally speaking, in any place where meeting permissions are necessarily required to see the model or certain fields, superadmins should no longer be implicitly assumed to have permission while this setting is turned on. Outsiders should still be able to see the meeting itself and whether a user is a member, but not any other relevant internal data. Now: I do not know, whether any more of the meeting model should be specially restricted away. I imagine that vast parts of what we consider the settings might need to be locked away. I've asked @Elblinator to do the appropriate conceptualization work with @MSoeb . Also I can imagine that this is going to be a lot of work. It may be a good idea to merge this PR for the sake of meta repo consistency and then work on the restrictor in a separate PR. As for what I can definitely say: |
The spefications what exactly we need from the autoupdate will be written in it's own Issue soon |
To change the visibility of the superadmin is a fundamental change that has to be discussed in detail. Currently, the superadmin skips the restriction and there are no negative restrictions. If we want to introduce this, the superadmin has to be handled as any other user. In this case, we have to look into any restriction mode there is. |
We merged this PR to have the same meta repo. If and how this gets implemented in the autoupdate service is something else. |
Triggered by commit 5eb31b946e9a9aea2470597fde7ae5ec2e6a5da1