Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split connection count metirc for longpolling #929

Merged

Conversation

ostcar
Copy link
Member

@ostcar ostcar commented May 1, 2024

This PR changes the metric values. See the changes in the README.

@ostcar ostcar requested a review from peb-adr May 1, 2024 07:17
@ostcar ostcar added the enhancement General enhancement which is neither bug nor feature label May 1, 2024
@ostcar ostcar added this to the 4.2 milestone May 1, 2024
@ostcar ostcar linked an issue May 1, 2024 that may be closed by this pull request
internal/http/http.go Outdated Show resolved Hide resolved
@peb-adr peb-adr added the staging label May 2, 2024
@peb-adr peb-adr merged commit 11de116 into OpenSlides:main May 2, 2024
2 checks passed
@ostcar ostcar deleted the split_connection_count_metirc_for_longpolling branch May 2, 2024 15:15
peb-adr pushed a commit to peb-adr/openslides-autoupdate-service that referenced this pull request May 2, 2024
peb-adr added a commit that referenced this pull request May 2, 2024
@bastianjoel
Copy link
Member

This was a breaking change for the api used by the client which caused a bug. Maybe assign someone who works on the client next time.

@ostcar
Copy link
Member Author

ostcar commented May 15, 2024

I am sorry. I only though about the graphana metric. I was not aware at the moment, that the values are also used by the client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement General enhancement which is neither bug nor feature staging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend Metric-Logs: longpolling
3 participants