Add identical motions #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 14, 2024
jsangmeister
added
the
waiting
|
I don't get this PR. The changes in the meta-repo seem not to be in main. Should this be a feature branch? If not, you should first merge the changes in the meta repo |
|
If you don't want to merge this yet, then please change this in a Draft PR |
jsangmeister
commented
Feb 20, 2024
| @@ -5135,6 +5135,15 @@ func (r *Fetch) Motion_ID(motionID int) *ValueInt { | |||
| return &ValueInt{fetch: r, key: key} | |||
| } | |||
|
|
|||
| func (r *Fetch) Motion_IDenticalMotionIDs(motionID int) *ValueIntSlice { | |||
There was a problem hiding this comment.
@ostcar Do you somewhere to a hard replace on "id" to write it uppercase? :D this function name seems suspicious....
There was a problem hiding this comment.
It seems this way :)
Here is the place:
Maybe it needs a better heuristic.
peb-adr
added a commit
that referenced
this pull request
Mar 12, 2024
* commit '441c4d9b6e7aff5f82baa8bbbdde05240e6436f8': (27 commits) Update meta repository (#885) Update meta (#877) Automatically create PRs for commits on staging branches (#865) Change restricter for motion_change_recommendation (#857) Bump github.com/klauspost/compress from 1.17.6 to 1.17.7 (#856) Remove update-generated-files.yml (#854) Update meta repository (#853) Bump github.com/gomodule/redigo from 1.8.9 to 1.9.1 (#852) new settings for one participant multiple times in the LoS (#851) Add identical motions (#846) Enhance motion fields (#844) Update go version (#850) Add motion restriction mode for `is_internal` (#847) Unify name of the openslides-meta submodule (#843) Add new restrictions for LoS extension (#807) (#810) Update meta repository (#841) Bump golang.org/x/sys from 0.16.0 to 0.17.0 (#839) Bump github.com/klauspost/compress from 1.17.5 to 1.17.6 (#836) Use models.yml from meta repo (#834) Bump github.com/jackc/pgx/v5 from 5.5.2 to 5.5.3 (#835) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needed for OpenSlides/OpenSlides#6722