Remove all text informations from motion slides when… #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ostcar
approved these changes
May 19, 2023
|
@emanuelschuetze can you please test if this breaks the motion or amendment projection? If everything's fine it can be merged |
|
@emanuelschuetze ping |
|
@emanuelschuetze is this still needed? |
|
@emanuelschuetze I close this for now. Please reopen if it should be merged. |
rrenkert
reviewed
Aug 29, 2023
internal/projector/slide/motion.go
Outdated
| @@ -171,7 +173,7 @@ func Motion(store *projector.SlideStore) { | |||
| "recommendation_extension_reference_ids", | |||
| } | |||
| if meeting.MotionsEnableTextOnProjector { | |||
| fetchFields = append(fetchFields, "text") | |||
| fetchFields = append(fetchFields, "text", "amendment_paragraph_$", "statute_paragraph_id") | |||
There was a problem hiding this comment.
After updating to current main (including "remove-template-fields") this will be "amendment_paragraphs" instead "amendment_paragraph_$".
luisa-beerboom
force-pushed
the
c-2218-remove-all-text-like-fields-if-text-should-not-be-shown
branch
from
741c647 to
2524722
Compare
peb-adr
added a commit
that referenced
this pull request
Sep 6, 2023
* commit '6615b167707057d26e4ed17b865a358973b06c56': (49 commits) Bump actions/checkout from 3 to 4 (#766) Remove all text informations from motion slides when… (#687) Debug agenda_item meetingID (#757) Connection count for admin (#761) use context.withoutCancel (#760) Make dsfetch simpler (#759) Remove dsfetch.error later (#758) Update the readme (#748) Fix go.sum after merge Merge main into feature/remove-template-fields (#751) update generated files (#750) Go 1.21 (#747) Fix cache.fetchMissing (#746) Change key representation (#738) Bump github.com/jackc/pgx/v5 from 5.4.2 to 5.4.3 (#744) Bump golang.org/x/sys from 0.10.0 to 0.11.0 (#743) New API for the search service (#721) Exit early on pendingmap (#742) Rtf profiling routes and updates (#741) Extend project automation (#740) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…enable_text_on_projector is turned off
See second point of this comment for background