Efficiency improvements to coverage plans with large ring-sizes (re-s…#36
Open
martinsumner wants to merge 1 commit intoopenriak-3.4from
Open
Efficiency improvements to coverage plans with large ring-sizes (re-s…#36martinsumner wants to merge 1 commit intoopenriak-3.4from
martinsumner wants to merge 1 commit intoopenriak-3.4from
Conversation
…ubmit) Remove unnecessary sort, once per loop. For each split mark, cache the calculation of the vnode list as a persistent_term. These will never change, and there will be a need for RingSize terms per node - and is bounded to that upper limit. Second attempt at commit, after making inadvertent commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ubmit)
Remove unnecessary sort, once per loop.
For each split mark, cache the calculation of the vnode list as a persistent_term. These will never change, and there will be a need for RingSize terms per node - and is bounded to that upper limit.
Second attempt at commit, after making inadvertent commit.
#35
Will also require minor doc amendment, adding a note to https://openriak.github.io/riak/InitialDesignDecisions.html#ring-size