-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace QPDF by PDFio as PDF manipulation library in libcupsfilters #71
base: master
Are you sure you want to change the base?
Conversation
removing comments of _cfPDFToPDFMakePage
Removing commented code for _cfPDFToPDFMakePage
…emoved the (_cfPDFToPDFMakePage) declaration as function not called anywhere
…rom qpdf to pdfio
…anges in function names, the other function files which were dependent on these file, were hindering the run process
…ctive calling of functions in bannertopdf.c and ghostscript.c, updated the file name in makefile
There is still one single C++ source file: Another point is the naming of the files you have created. Could you all rename them removing the |
By the way, your work has passed the included build and CI tests. Could you add further test cases to the file |
Sure, letme go through the poppler Library as I haven't studied anything about it. Then I would port pdftorastor.cxx into C as well. I will remove the I will also start with test cases as well |
Your last commit just adds the new files but named without |
removing qpdf installing from testing as it has been eliminated
- In Makefile.am for building libcupsfilters - In libcupsfilters.pc.in, the "Libs.private" entry Also replaced a hardcoded "-lcups" by $(CUPS_LIBS) in Makefile.am
the new features of pdfio have been updated in file cupsfilters/pdftopdf/pdfio-pdftopdf-processor.c
As the libcupsfilters library is principally written in regular C and not C++ due to the issues which would occur due to use of C++. But libcupsfilters still depend on one library which is written in C++, QPDF, a library for manipulation of PDF files. We need to replace this dependency on C++, with another library PDFio. This is a PDF handling and manipulation library, as QPDF is, but it is fully written in standard, regular C, not in C++.