Adopt term 'Map reference point' #2029
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dg0yt
changed the title
dl3sdo
force-pushed
the
map-scale-rotate
branch
from
6a75588 to
ebb3724
Compare
dl3sdo
force-pushed
the
map-scale-rotate
branch
from
ebb3724 to
07eef0e
Compare
|
Rebase and split of previous commit to separate changes for each affected file. |
dl3sdo
force-pushed
the
map-scale-rotate
branch
from
07eef0e to
e3a3ecd
Compare
dl3sdo
force-pushed
the
map-scale-rotate
branch
from
e3a3ecd to
c2dde01
Compare
dl3sdo
changed the title
In the 'Rotate map', 'Change map scale' and 'Change scale factor' dialogs, the rotation/scaling center can be chosen to be the 'Georeferencing reference point', even for local CRS. This is confusing since the reference point is based on map coordinates (e.g., in mm) and not on geographic coordinates. In the 'Options' section below the term 'Adjust georeferencing reference point' also only refers to the coordinates of the map reference point.
dl3sdo
force-pushed
the
map-scale-rotate
branch
from
c2dde01 to
4f8699a
Compare
|
@pkturner: The initial commit ignored the StretchMapDialog dialog that uses the same wordings. Please check, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the 'Rotate map', 'Change map scale' and 'Change scale factor' dialogs, the rotation/scaling center can be chosen to be the 'Georeferencing reference point', even for local CRS.
This is confusing since the reference point is based on map coordinates (e.g., in mm) and not on geographic coordinates.
In the 'Options' sections below the term 'Adjust georeferencing reference point' also only refers to the
coordinates of the map reference point.
This change implements Scott Turner's (@pkturner) proposal to use 'Map reference point' and 'Adjust coordinates of map reference point' instead.
It supersedes #2014.