Fix for getting a clean struct in each VM looped in scheduler #7072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
In scheduling loop HostShareCapacity object contained numa nodes from previous virtual machine. This caused scheduling to fail sometimes even if there would be a suiteable host. Fixed by recreating the object inside the loop for every virtual machine. Signed-off-by: Tony Sarajärvi <tony.sarajarvi@qt.io>
paczerny
approved these changes
Jun 8, 2025
Member
|
It's already fixed in master (version 7.0). Apply only to 6.10 branch |
Member
|
OK THANKS! ❤️ Merged in 6.10 branch for 6.10.5 release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When looping through VMs in the scheduler, not all previous data was cleared before or at get_capacity. This leaked old VM requirements to the next one blocking the scheduler in certain circumstances. This fix will ensure a clean struct for each VM in the loop.
Branches to which this PR applies