Open
Conversation
|
Is this PR still WIP? Any update when this will be done? Or if you need any help in this PR? I might be of some use? |
Member
|
not sure where @anderleich left this on hold. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ATTENTION! I'm opening a new PR to add target features only.
The previous PR was #2289. Closed
This PR intends to add target features support to OpenNMT-py. Target features are appended to the textual data. It uses the special character
│as a feature separator, as in the previous versions of the OpenNMT framework.Target features can be used along source features. A YAML configuration file would look like this:
@vince62s for the moment I've just copied all the necessary changes from #2289.