Make Mage_GiftMessage optional in templates

[Hanmac]

Description (*)

This makes all templates use functions in their blocks to check isModuleEnabled('Mage_GiftMessage') first

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Mage_GiftMessage shouldn't be required for Mage_Adminhtml #4263

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All automated tests passed successfully (all builds are green)
• Add yourself to contributors list

[sreichel]

Nice!

For the template you edit, can you please check that this is at top ...

/**
 * @see Mage_Some_Block_Name
 * @var Mage_Some_Block_Name $this
 */

[Hanmac]

Yeah, that annoyed me when i was looking at the templates

Does it need @see if it already has @var this?

[sreichel]

No. var is more importan.

[sreichel]

Great. :)

Can you please add return types to newly added methods?

[Hanmac]

canDisplayGiftmessage() could be existing methods, but I still touched them, so they should be updated?

[sreichel]

To not break anything i'd not change existing methods.

[Hanmac]

To not break anything i'd not change existing methods.

imo, if getLayout->getBlock returns something else than Mage_Core_Block_Abstract,
their code is already broken, they just don't know it yet

[sreichel]

Very nice. Thanks for fixing phpstan issues too.

First i thought it would be small change ... but no. :)

Lets wait for #4323. It could replace all Mage::helper('core')->isModuleOutputEnabled()

[fballiano]

is this correct? changing from item to parentitem?

[fballiano]

this was also changed from item to parentitem, and some other times in this PR

[kiatng]

Yes, the change makes sense. See

magento-lts/app/design/frontend/rwd/default/template/bundle/email/order/items/shipment/default.phtml

Lines 28 to 32 in 3a2a11c

	<?php if($this->getItemOptions() || $parentItem->getDescription() || $this->canDisplayGiftmessage()): ?>
	<?php $_showlastRow = true ?>
	<?php else: ?>
	<?php $_showlastRow = false ?>
	<?php endif ?>

$_showlastRow = true when there is something in $parentItem->getDescription()

$_item is from <?php foreach ($items as $_item): ?>. So, based on these, the change should be correct.