Fix for variable bus from pre- to post-mission subsystem#1005
Open
irianordaz wants to merge 6 commits intoOpenMDAO:mainfrom
Open
Fix for variable bus from pre- to post-mission subsystem#1005irianordaz wants to merge 6 commits intoOpenMDAO:mainfrom
irianordaz wants to merge 6 commits intoOpenMDAO:mainfrom
Conversation
aviary/core/aviary_group.py
Outdated
| self.connect( | ||
| f'pre_mission.{bus_variable}', | ||
| post_mission_var_name, | ||
| f'pre_mission.{subsystem.name}.{bus_variable}', |
Member
There was a problem hiding this comment.
The change in these two lines needs to be reverted.
aviary/core/aviary_group.py
Outdated
|
|
||
| for post_mission_var_name in post_mission_var_names: | ||
|
|
||
| if '.' in post_mission_var_name: |
Member
There was a problem hiding this comment.
I think this split here will break if the user wants to connect to an unpromoted input like post_mission.sub1.sub2.comp.x. We should probably remove it, and change the target in the connect back to post_mission_var_name.
| self.connect( | ||
| f'pre_mission.{bus_variable}', | ||
| post_mission_var_name, | ||
| f'{post_mission_var_name}', |
Member
There was a problem hiding this comment.
Probably cleanest to remove the formatted string now that it isn't needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the subsystem builder bus to allow passing variables from pre-mission to post-mission. Previously, the connections were only made when the parameter contained a target in "mission". If the parameter contained a target only in post_mission, an error would occur.
Related Issues
Backwards incompatibilities
None
New Dependencies
None