Skip to content

Load mass rework#1002

Open
nathanperreau wants to merge 11 commits intoOpenMDAO:mainfrom
nathanperreau:load_mass_rework
Open

Load mass rework#1002
nathanperreau wants to merge 11 commits intoOpenMDAO:mainfrom
nathanperreau:load_mass_rework

Conversation

@nathanperreau
Copy link
Contributor

Summary

This work relates to task #752, breaking apart the equipment and useful load GASP mass class. A variety of smaller components were created to simplify the equipment_and_useful_load class. The summation and calculation components are split up now as well.

The majority of the other changes on the branch relate to modifying test cases for component testing, and all-encompassing testing.

Related Issues

Backwards incompatibilities

None

New Dependencies

None

@Kenneth-T-Moore
Copy link
Member

Kenneth-T-Moore commented Feb 25, 2026

I think the main issue that causes the optimization results to change is the unusable fuel mass, which was missing before but now is computed and passed into the fuel balances.

Copy link
Contributor

@jkirk5 jkirk5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

furnishing, anti_icing, apu, avionics, emergency equipment masses all missing from summations, and are therefore throwing off higher-level mass values

@jkirk5
Copy link
Contributor

jkirk5 commented Feb 25, 2026

furnishing, anti_icing, apu, avionics, emergency equipment masses all missing from summations, and are therefore throwing off higher-level mass values

Seems like these are overrides, so I am still trying to figure out how an off-design mission with fixed mass is producing different results than main

@Kenneth-T-Moore
Copy link
Member

Kenneth-T-Moore commented Feb 25, 2026

furnishing, anti_icing, apu, avionics, emergency equipment masses all missing from summations, and are therefore throwing off higher-level mass values

Seems like these are overrides, so I am still trying to figure out how an off-design mission with fixed mass is producing different results than main

z

The new components compute an unusable fuel mass, which is extra mass it has to carry now once everything is balanced..

@jkirk5
Copy link
Contributor

jkirk5 commented Feb 25, 2026

The new components compute an unusable fuel mass, which is extra mass it has to carry now once everything is balanced..

That fuel weight was already accounted for under useful load before, so it shouldn't have changed any top-level masses here (now it it finally is being tracked under its own variable). Maybe it is getting double counted?

@Kenneth-T-Moore
Copy link
Member

The new components compute an unusable fuel mass, which is extra mass it has to carry now once everything is balanced..

That fuel weight was already accounted for under useful load before, so it shouldn't have changed any top-level masses here (now it it finally is being tracked under its own variable). Maybe it is getting double counted?

Oh, yeah. That is possible. If it is already in the mass summation, then the fact that it is now output as a variable caused it to promote and connect in to this balance component.

@jkirk5 jkirk5 marked this pull request as ready for review February 25, 2026 22:14
Copy link
Contributor

@jkirk5 jkirk5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to go once we resolve the non-converging bench test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Break EquipAndUsefulLoadMass class into detailed components, each computes one component mass

3 participants