Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that volume IDs are unique #666

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gertvanhoey
Copy link
Contributor

@gertvanhoey gertvanhoey commented Jan 11, 2025

Fixes #655

The format of "PreStepUniqueVolumeID" is now <volume name>-<volume copy numbers>. A - has been chosen as separator, because _ may be confusing if the <volume name> ends with a number (e.g. in case of volume repetition).

The test that was added has the following output:

4 volumes have been hit: {'crystal_no_repeat2-0_0', 'crystal_repeat_rep_0-0_0', 'crystal_no_repeat1-0_0', 'crystal_repeat_rep_1-0_1'}

In GateUniqueVolumeIDManager, the map uses the combination of name and numbers (ID array) as a key to make sure each volume has unique key.

@dsarrut
Copy link
Contributor

dsarrut commented Jan 16, 2025

Excellent Gert, thanks a lot! There is still one failed job, I dont understand why, but it is not related to your changes. I will investigate ...
Maybe related to #664

@gertvanhoey
Copy link
Contributor Author

Happy to be able to contribute! Concerning the failed test, I've seen this in my previous PR too. It was not the same job that failed, but it was also one job out of all the test jobs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple volumes at the same level in the volume hierarchy result in duplicate volume IDs
2 participants