Ensure that volume IDs are unique #666
Open
+127
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #655
The format of
"PreStepUniqueVolumeID"
is now<volume name>-<volume copy numbers>
. A-
has been chosen as separator, because_
may be confusing if the<volume name>
ends with a number (e.g. in case of volume repetition).The test that was added has the following output:
In
GateUniqueVolumeIDManager
, the map uses the combination of name and numbers (ID array) as a key to make sure each volume has unique key.