Coin sorter V2 corrected with tests

[kochebina]

@tbaudier @nkrah @dsarrut

I don't know what happened to the prev. PR for CoinSorter... but here it the new one.
The corrected version of it is in this PR.
It is ready!

The ref data to be copied to opengate/tests/data/output_ref/test072 is here:
https://doi.org/10.6084/m9.figshare.28063244.v1

[tbaudier]

Hello @kochebina

I integrated the data but the tests are failling. For example:

(venv) (base) tbaudier@eq4-tb-693 src % python test072_coinc_sorter_2keep_all.py
Opening /Users/tbaudier/Software/GatePython/opengate/opengate/tests/output/test072_coinc_sorter/test72_output_1.root ...
There are 7685 singles
{'EventID': 'int32_t', 'PostPosition_X': 'double', 'PostPosition_Y': 'double', 'PostPosition_Z': 'double', 'TotalEnergyDeposit': 'double', 'PreStepUniqueVolumeID': 'char*', 'GlobalTime': 'double'}
Traceback (most recent call last):
  File "/Users/tbaudier/Software/GatePython/opengate/opengate/tests/src/test072_coinc_sorter_2keep_all.py", line 69, in <module>
    main()
  File "/Users/tbaudier/Software/GatePython/opengate/opengate/tests/src/test072_coinc_sorter_2keep_all.py", line 48, in main
    coincidences = coincidences_sorter(
TypeError: coincidences_sorter() missing 1 required positional argument: 'maxDistanceZ'

[kochebina]

Hello @tbaudier,

I removed the old tests that are failing. Sorry for this oversight.

Cheers,
Olga

Hello @kochebina

I integrated the data but the tests are failling. For example:

(venv) (base) tbaudier@eq4-tb-693 src % python test072_coinc_sorter_2keep_all.py
Opening /Users/tbaudier/Software/GatePython/opengate/opengate/tests/output/test072_coinc_sorter/test72_output_1.root ...
There are 7685 singles
{'EventID': 'int32_t', 'PostPosition_X': 'double', 'PostPosition_Y': 'double', 'PostPosition_Z': 'double', 'TotalEnergyDeposit': 'double', 'PreStepUniqueVolumeID': 'char*', 'GlobalTime': 'double'}
Traceback (most recent call last):
  File "/Users/tbaudier/Software/GatePython/opengate/opengate/tests/src/test072_coinc_sorter_2keep_all.py", line 69, in <module>
    main()
  File "/Users/tbaudier/Software/GatePython/opengate/opengate/tests/src/test072_coinc_sorter_2keep_all.py", line 48, in main
    coincidences = coincidences_sorter(
TypeError: coincidences_sorter() missing 1 required positional argument: 'maxDistanceZ'

[kochebina]

Salut Thomas, Si on revient sur le 10 et le CoinSorter: il faut retirer de tests les anciens tests: test072_coinc_sorter_step2_config1removeMultiples.py : failed test072_coinc_sorter_step2_config2minDistanceXY.py : failed test072_coinc_sorter_step2_config2takeWinnerIfIsGood.py : failed Je l'ai fait dans mon PR mais il faut les retirer des tests qu'on passe sinon le PR passera jamais :-) Et encore une fois je ne sais pas comment le faire et même si j'ai les droits... A+ Olga Le ven. 20 déc. 2024 à 11:10, tbaudier ***@***.***> a écrit :

…

Hello @kochebina <https://github.com/kochebina> I integrated the data but the tests are failling. For example: (venv) (base) ***@***.*** src % python test072_coinc_sorter_2keep_all.py Opening /Users/tbaudier/Software/GatePython/opengate/opengate/tests/output/test072_coinc_sorter/test72_output_1.root ... There are 7685 singles {'EventID': 'int32_t', 'PostPosition_X': 'double', 'PostPosition_Y': 'double', 'PostPosition_Z': 'double', 'TotalEnergyDeposit': 'double', 'PreStepUniqueVolumeID': 'char*', 'GlobalTime': 'double'} Traceback (most recent call last): File "/Users/tbaudier/Software/GatePython/opengate/opengate/tests/src/test072_coinc_sorter_2keep_all.py", line 69, in <module> main() File "/Users/tbaudier/Software/GatePython/opengate/opengate/tests/src/test072_coinc_sorter_2keep_all.py", line 48, in main coincidences = coincidences_sorter( TypeError: coincidences_sorter() missing 1 required positional argument: 'maxDistanceZ' — Reply to this email directly, view it on GitHub <#652 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKBSL7MWTZHAWCTNHRHU4VD2GPUKNAVCNFSM6AAAAABT5OVKN6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNJWGY4DINRTGQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[kochebina]

For commit d091b94
the data should be used from here:
https://figshare.com/s/32013fc0f390238acbbb