Doc 4 CoinSorter #557
Open
Doc 4 CoinSorter #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbaudier
requested changes
Nov 18, 2024
| fatal( | ||
| f"Error, the policy for the Coincidence Sorter must be removeMultiples or " | ||
| f"keepAll, while is is '{self.policy}'" | ||
| ) | ||
|
|
||
|
|
||
| def coincidences_sorter( |
There was a problem hiding this comment.
Maybe move all following functions into Coincidences class?
There was a problem hiding this comment.
I didn't manage to make it work. Keep it this way for the moment
| from .base import ActorBase | ||
|
|
||
|
|
||
| class Coincidences(ActorBase): |
There was a problem hiding this comment.
Add process_cls(...) at the end of the file
eg: https://github.com/OpenGATE/opengate/blob/master/opengate/actors/arfactors.py#L416
| from .base import ActorBase | ||
|
|
||
|
|
||
| class Coincidences(ActorBase): |
There was a problem hiding this comment.
Add the class to init file: https://github.com/OpenGATE/opengate/blob/master/opengate/actors/__init__.py
Closed
|
sorry, there is still misunderstanding of what a class and an Actor is used for. We will discuss together |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation for coincidence sorter (simplified version)