-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added description of plugins mechanism in README #38
base: main
Are you sure you want to change the base?
Added description of plugins mechanism in README #38
Conversation
Signed-off-by: Christian Pinto <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the one comment in the README file
Signed-off-by: Christian Pinto <[email protected]>
@cayton could you please have a look at this PR? Thanks |
Looks good - one comment/question - in the line about Objects handlers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the line about Object Handlers, the examples used are "get, create, replace, patch, delete" - is this what we want to use or should we use the more canonical "get, post, put, patch, delete"?
We are using a different naming convention on purpose because those are not HTTP call handlers. The HTTP part is to be implemented by the server that imports the sunfish library. |
@cayton please approve the PR if it is ok for you. Thanks |
Added description of plugins mechanism in README