Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added description of plugins mechanism in README #38

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

christian-pinto
Copy link
Collaborator

Added description of plugins mechanism in README

README.md Show resolved Hide resolved
Copy link
Collaborator

@rherrell rherrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one comment in the README file

Signed-off-by: Christian Pinto <[email protected]>
@christian-pinto
Copy link
Collaborator Author

@cayton could you please have a look at this PR? Thanks

@cayton
Copy link

cayton commented Sep 23, 2024

Looks good - one comment/question - in the line about Objects handlers
Is it correct to use "get, create, replace, patch, delete" as the examples or should we use the more canonical "get, post, put, patch, delete" for clarity?

@cayton cayton closed this Sep 23, 2024
Copy link

@cayton cayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the line about Object Handlers, the examples used are "get, create, replace, patch, delete" - is this what we want to use or should we use the more canonical "get, post, put, patch, delete"?

@christian-pinto
Copy link
Collaborator Author

In the line about Object Handlers, the examples used are "get, create, replace, patch, delete" - is this what we want to use or should we use the more canonical "get, post, put, patch, delete"?

Looks good - one comment/question - in the line about Objects handlers Is it correct to use "get, create, replace, patch, delete" as the examples or should we use the more canonical "get, post, put, patch, delete" for clarity?

We are using a different naming convention on purpose because those are not HTTP call handlers. The HTTP part is to be implemented by the server that imports the sunfish library.

@christian-pinto
Copy link
Collaborator Author

@cayton please approve the PR if it is ok for you. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants