Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: track decimation #1724

Closed
wants to merge 1 commit into from
Closed

Conversation

pierotofy
Copy link
Member

This PR brings the changes suggested from mapillary/OpenSfM#641 into ODM.

On small datasets this seems to decrease relative accuracy, so perhaps this might need to be adjusted to only be used on larger datasets (how large?)

Please help test, in particular:

  • How does relative/absolute accuracy change relative to the current baseline?
  • How do the final outputs look relative to the current baseline?
  • What are the runtime differences for the OpenSfM stage?

@smathermather
Copy link
Contributor

What sizes do you want / need tested?

@pierotofy
Copy link
Member Author

A variety would be best (small, medium, large), but the main concern is just trying to answer the bullet points I mentioned above.

@smathermather
Copy link
Contributor

smathermather commented Nov 21, 2023

Cool. I've got it running on a 1900 dataset. Seems like a decent size (larger than most test datasets) without taking overly long to run (should be done tomorrow afternoon). All defaults, one running on current and one on a fresh build of this branch.

@smathermather
Copy link
Contributor

So far, I don't think I see any computational time differences in OpenSfM:
image

@smathermather
Copy link
Contributor

Only difference I see so far is progress bar differences for the same stage:
image

@smathermather
Copy link
Contributor

Definitely got some weird errors in the northeastern corner:

Kakuma_17A_Flight_02-report.pdf
Kakuma_17A_Flight_02-trackdec-report.pdf

image

trackdec left, current right

image

@pierotofy pierotofy closed this Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants