Hash as_json handle unlimited items #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #876 +/- ##
=======================================
Coverage 74.09% 74.09%
=======================================
Files 612 612
Lines 42887 42887
Branches 877 877
=======================================
Hits 31776 31776
+ Misses 11017 11015 -2
- Partials 94 96 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
jmthomas
commented
Oct 17, 2023
| @@ -115,9 +115,9 @@ def as_json(options = nil) #:nodoc: | |||
|
|
|||
| class Hash | |||
| def as_json(options = nil) #:nodoc: | |||
| pairs = [] | |||
| self.each { |k, v| pairs << k.to_s; pairs << v.as_json(options) } | |||
| Hash[*pairs] | |||
There was a problem hiding this comment.
This was overwhelming the stack with the huge amount of items and causing a 'Stack too deep' error.
ryanmelt
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #863