Fix Python Logger and Pool #868
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #868 +/- ##
==========================================
- Coverage 72.66% 72.66% -0.01%
==========================================
Files 611 611
Lines 42273 42263 -10
Branches 870 870
==========================================
- Hits 30719 30711 -8
+ Misses 11461 11459 -2
Partials 93 93
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
| try: | ||
| yield item | ||
| finally: | ||
| self.pool.put(item) |
There was a problem hiding this comment.
Was this losing items if the yield raised an exception?
There was a problem hiding this comment.
I don't know where it was losing items, but it definitely was. This was eventually causing the decom lockup because it was waiting forever for a redis instance to be available.
| or func == "my_instance" | ||
| or func == "scope" | ||
| or func == "__dict__" | ||
| ): |
There was a problem hiding this comment.
Would like to see this as an array of values with a comment. Then you can do if func in ATTR_NAMES: or whatever you call it. Comment on where these names come from.
Same for the next three examples.
|
Looks like this really broke the python unit tests. I think it has to do with the NO_STORE variable and how that is getting set and used. |
|
The NO_STORE logic was completely wrong before this fix. INST2 wasn't printing any log messages. |
|
Kudos, SonarCloud Quality Gate passed!
|
No description provided.