REDUCER_DISABLE option for targets #826
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #826 +/- ##
==========================================
- Coverage 72.75% 72.75% -0.01%
==========================================
Files 472 472
Lines 30772 30782 +10
Branches 877 877
==========================================
+ Hits 22389 22396 +7
- Misses 8288 8292 +4
+ Partials 95 94 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
| # Disable data reduction (min, hour, day) on this target data | ||
| # No 'ruby reducer_microservice.rb DEFAULT__REDUCER__EXAMPLE' | ||
| # will appear in the the process list | ||
| DISABLE_REDUCER |
There was a problem hiding this comment.
Change to REDUCER_DISABLE to be consistent of starting with REDUCER_
| <% end %> | ||
|
|
||
| <% if include_inst2 %> | ||
| TARGET INST <%= inst2_target_name %> | ||
| LOG_RETAIN_TIME <%= log_retain_time %> | ||
| REDUCED_LOG_RETAIN_TIME <%= reduced_log_retain_time %> | ||
| TLM_LOG_CYCLE_TIME 600 | ||
| # Allow the reducer microservice to take 10% of the cpu (default 30%) | ||
| REDUCER_MAX_CPU_UTILIZATION 10 |
There was a problem hiding this comment.
This is really low for the heaviest target
There was a problem hiding this comment.
I'll change it ... but speaking of that. Can the reducer know it's falling behind and raise a notification?
There was a problem hiding this comment.
If the minute reducer takes longer than a minute, then there is probably a problem
There was a problem hiding this comment.
There are cases where that would be fine though. Like if you dropped in a whole bunch of files to process at once and it just takes a long time to work through
There was a problem hiding this comment.
Probably worth a notification.
jmthomas
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
closes #801