Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display raw UINT/INT values as hex #821

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Display raw UINT/INT values as hex #821

merged 2 commits into from
Sep 13, 2023

Conversation

jmthomas
Copy link
Member

closes #775

@jmthomas jmthomas requested a review from ryanmelt September 12, 2023 00:29
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (44a09f4) 72.73% compared to head (85af3e4) 72.72%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #821      +/-   ##
==========================================
- Coverage   72.73%   72.72%   -0.02%     
==========================================
  Files         472      472              
  Lines       30774    30774              
  Branches      878      878              
==========================================
- Hits        22384    22379       -5     
- Misses       8295     8303       +8     
+ Partials       95       92       -3     
Flag Coverage Δ
ruby-api 50.67% <ø> (ø)
ruby-backend 80.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

this.rawValue = '0x' + values[0][0].toString(16).toUpperCase()
} else {
this.rawValue = values[0][0]
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted hex to be in addition to the decimal display, not replace it.

Copy link
Member Author

@jmthomas jmthomas Sep 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like 0xA (10) or 10 (0xA)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That or a separate line. Either would be fine.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of those: 10 (0xA)

@jmthomas
Copy link
Member Author

Screenshot 2023-09-12 at 10 41 55 PM

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jmthomas jmthomas merged commit 6120962 into main Sep 13, 2023
24 checks passed
@jmthomas jmthomas deleted the hex_raw_details branch September 13, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get Details dialog should show RAW as hex
2 participants