PacketViewer config bugs #1806
PacketViewer config bugs #1806
Conversation
This fixes the bug where PacketViewer appeared to not remember the last selected packet in the default config
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1806 +/- ##
==========================================
+ Coverage 79.56% 79.58% +0.01%
==========================================
Files 517 517
Lines 40737 40737
==========================================
+ Hits 32414 32419 +5
+ Misses 8323 8318 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
| if (val) { | ||
| this.selectedItemName = val.toUpperCase() | ||
| } | ||
| }, |
There was a problem hiding this comment.
So this is the bug fix because we were updating initalTargetName after the use ... I see it was only ever set in data. How did this ever work?
There was a problem hiding this comment.
Discussed during scrum, but I'm not sure how this ever worked, but I suspect the TargetPacketItemChooser was being destroyed and recreated or something like that.
| this.$router.push({ | ||
| name: 'PackerViewer', | ||
| params: {}, | ||
| }) |
There was a problem hiding this comment.
Nice ... I think there's probably other places in COSMOS where we're "remembering" previous values but the most obvious is here in Packet Viewer
Fixed bugs:
I couldn't find github issues for these, but they were discussed in scrum at some point