Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix eslint config #1792

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Fix eslint config #1792

merged 1 commit into from
Dec 20, 2024

Conversation

ryan-pratt
Copy link
Contributor

@vue/eslint-config-prettier v10.0.0 removed support for the legacy config format that we were using with compat.extends([...] "@vue/prettier"). Replaced that with the new flat format.

Also:

  • removed the vue stuff from js-common's config
  • bumped ace-diff ecmaVersion so it matches everything else
  • cleaned up some ugliness that was generated by the eslint flat config migration tool

@ryan-pratt ryan-pratt requested a review from jmthomas December 20, 2024 19:20
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.58%. Comparing base (34889a4) to head (9216eb3).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1792      +/-   ##
==========================================
+ Coverage   79.56%   79.58%   +0.01%     
==========================================
  Files         517      517              
  Lines       40737    40737              
==========================================
+ Hits        32412    32420       +8     
+ Misses       8325     8317       -8     
Flag Coverage Δ
python 84.30% <ø> (+0.05%) ⬆️
ruby-api 48.64% <ø> (ø)
ruby-backend 82.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ryan-pratt ryan-pratt merged commit 2685dc8 into main Dec 20, 2024
27 of 28 checks passed
@ryan-pratt ryan-pratt deleted the fix-eslint branch December 20, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants