Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add computedStyle to ROLLUP, LED, and SIGNAL widgets #1781

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

jmthomas
Copy link
Member

closes #1780

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.57%. Comparing base (e9ecd6e) to head (af5eea1).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1781      +/-   ##
==========================================
- Coverage   79.58%   79.57%   -0.01%     
==========================================
  Files         517      517              
  Lines       40737    40737              
==========================================
- Hits        32420    32417       -3     
- Misses       8317     8320       +3     
Flag Coverage Δ
python 84.28% <ø> (-0.03%) ⬇️
ruby-api 48.64% <ø> (ø)
ruby-backend 82.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmthomas
Copy link
Member Author

This definition:

SCREEN AUTO AUTO 1.0

HORIZONTAL 20
  ROLLUP satellite-transmit
  ROLLUP satellite-receive
  ROLLUP notifications
END

VERTICAL 20
  LED INST PARAMS VALUE5 RAW 25 20 # Ellipse
    SETTING LED_COLOR 0 GREEN
    SETTING LED_COLOR 1 RED
  LED INST PARAMS VALUE4 RAW 20 25 # Ellipse
    SETTING LED_COLOR 0 YELLOW
    SETTING LED_COLOR 1 BLUE
  LED INST PARAMS VALUE3 RAW 50 50
    SETTING LED_COLOR 0 GREEN
    SETTING LED_COLOR 1 RED
    SETTING LED_COLOR ANY ORANGE # All other values are ORANGE
  LED INST PARAMS VALUE2 # Default is WITH_UNITS 15 15
    SETTING LED_COLOR GOOD GREEN
    SETTING LED_COLOR BAD RED
  LED INST PARAMS VALUE1 CONVERTED 10 10
    SETTING LED_COLOR GOOD GREEN
    SETTING LED_COLOR BAD RED
END
HORIZONTAL 20
  LED INST PARAMS VALUE5 RAW 25 20 # Ellipse
    SETTING LED_COLOR 0 GREEN
    SETTING LED_COLOR 1 RED
  LED INST PARAMS VALUE4 RAW 20 25 # Ellipse
    SETTING LED_COLOR 0 YELLOW
    SETTING LED_COLOR 1 BLUE
  LED INST PARAMS VALUE3 RAW 20 20
    SETTING LED_COLOR 0 GREEN
    SETTING LED_COLOR 1 RED
    SETTING LED_COLOR ANY ORANGE # All other values are ORANGE
  LED INST PARAMS VALUE2 # Default is WITH_UNITS 15 15
    SETTING LED_COLOR GOOD GREEN
    SETTING LED_COLOR BAD RED
  LED INST PARAMS VALUE1 CONVERTED 10 10
    SETTING LED_COLOR GOOD GREEN
    SETTING LED_COLOR BAD RED
END

HORIZONTAL 20
  SIGNAL INST HEALTH_STATUS TEMP1 
  SIGNAL INST HEALTH_STATUS TEMP2
  SIGNAL INST HEALTH_STATUS TEMP3
END

Now results in this screen:
Screenshot 2024-12-18 at 3 34 24 PM

@jmthomas
Copy link
Member Author

In main it looks like this:
Screenshot 2024-12-18 at 3 38 27 PM

@jmthomas jmthomas merged commit 620b543 into main Dec 19, 2024
28 checks passed
@jmthomas jmthomas deleted the margins branch December 19, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ROLLUP, LED, and SIGNAL widget margins not applied
2 participants