Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add execute to TimelineModel and api in controller to set it #1760

Merged
merged 2 commits into from
Dec 14, 2024

Conversation

jmthomas
Copy link
Member

@jmthomas jmthomas commented Dec 13, 2024

This is similar to how we recently added shard. Do we need a migration or since it is a new attribute none is needed?

@jmthomas jmthomas requested a review from ryanmelt December 13, 2024 21:24
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 9 lines in your changes missing coverage. Please review.

Project coverage is 79.58%. Comparing base (5af74dc) to head (204289a).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...cmd-tlm-api/app/controllers/timeline_controller.rb 50.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1760      +/-   ##
==========================================
- Coverage   79.59%   79.58%   -0.02%     
==========================================
  Files         517      517              
  Lines       40713    40736      +23     
==========================================
+ Hits        32404    32418      +14     
- Misses       8309     8318       +9     
Flag Coverage Δ
python 84.30% <ø> (ø)
ruby-api 48.64% <52.63%> (+<0.01%) ⬆️
ruby-backend 82.61% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ryanmelt
Copy link
Member

Migrations depend on how the new attribute is used. If it is used correctly if not present then a migration is not needed. I'm guessing in Calendar you are expecting it to be there though in the JSON.

@ryanmelt ryanmelt merged commit a5556d6 into main Dec 14, 2024
28 checks passed
@ryanmelt ryanmelt deleted the timeline_exec branch December 14, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants