Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter Controllers stack trace #1731

Merged
merged 3 commits into from
Dec 5, 2024
Merged

Filter Controllers stack trace #1731

merged 3 commits into from
Dec 5, 2024

Conversation

jmthomas
Copy link
Member

@jmthomas jmthomas commented Dec 3, 2024

No description provided.

@jmthomas jmthomas requested a review from ryanmelt December 3, 2024 16:59
@@ -81,7 +81,7 @@ def self.delete(name:, scope:)
model.undeploy()
end

attr_reader :name, :scope, :snooze, :triggers, :actions, :enabled, :triggerLevel, :snoozed_until
attr_reader :name, :scope, :snooze, :triggers, :actions, :enabled, :trigger_level, :snoozed_until
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have an Enterprise migration to change this to the proper Ruby syntax

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 22.50000% with 93 lines in your changes missing coverage. Please review.

Project coverage is 76.72%. Comparing base (43b108d) to head (239c1e8).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...cmd-tlm-api/app/controllers/reaction_controller.rb 10.52% 17 Missing ⚠️
...cmd-tlm-api/app/controllers/activity_controller.rb 25.00% 15 Missing ⚠️
...-cmd-tlm-api/app/controllers/trigger_controller.rb 8.33% 11 Missing ⚠️
...-cmd-tlm-api/app/controllers/storage_controller.rb 0.00% 7 Missing ⚠️
...s-cmd-tlm-api/app/controllers/tables_controller.rb 0.00% 7 Missing ⚠️
...cmd-tlm-api/app/controllers/timeline_controller.rb 12.50% 7 Missing ⚠️
...lm-api/app/controllers/trigger_group_controller.rb 22.22% 7 Missing ⚠️
...-tlm-api/app/controllers/environment_controller.rb 25.00% 3 Missing ⚠️
...-cmd-tlm-api/app/controllers/targets_controller.rb 0.00% 3 Missing ⚠️
...api/app/controllers/internal_metrics_controller.rb 0.00% 2 Missing ⚠️
... and 10 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1731      +/-   ##
==========================================
+ Coverage   76.60%   76.72%   +0.11%     
==========================================
  Files         607      530      -77     
  Lines       46488    42207    -4281     
  Branches      844      270     -574     
==========================================
- Hits        35613    32382    -3231     
+ Misses      10778     9825     -953     
+ Partials       97        0      -97     
Flag Coverage Δ
frontend 3.49% <ø> (-52.85%) ⬇️
python 84.19% <ø> (-0.03%) ⬇️
ruby-api 48.64% <20.00%> (+0.03%) ⬆️
ruby-backend 82.53% <80.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Dec 5, 2024

@ryanmelt ryanmelt merged commit 48382e4 into main Dec 5, 2024
27 of 28 checks passed
@ryanmelt ryanmelt deleted the controllers branch December 5, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants