Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow execute selection while paused #1638

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow execute selection while paused #1638

wants to merge 1 commit into from

Conversation

jmthomas
Copy link
Member

@jmthomas jmthomas commented Oct 18, 2024

closes #555

All I did was allow the Execute Selection and Run from here while paused. All the other limitations apply which is you don't have any variables defined, etc and it's basically a new script. I think the real solution would be to run the selected text against the script binding context but not even sure that's possible with Python?

@jmthomas jmthomas requested a review from ryanmelt October 18, 2024 23:03
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.41%. Comparing base (6c85e08) to head (777d939).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1638   +/-   ##
=======================================
  Coverage   76.40%   76.41%           
=======================================
  Files         618      618           
  Lines       46858    46860    +2     
  Branches      845      846    +1     
=======================================
+ Hits        35803    35806    +3     
+ Misses      10959    10958    -1     
  Partials       96       96           
Flag Coverage Δ
frontend 56.14% <100.00%> (+0.01%) ⬆️
python 83.87% <ø> (+<0.01%) ⬆️
ruby-api 47.59% <ø> (ø)
ruby-backend 82.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Copy link
Member

@ryanmelt ryanmelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted, the point of "while paused" is to maintain the local variable context. Will require backend changes to work correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Execute Selection While Paused
2 participants