New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] SecCompanyFilings: Purge `nan` Values & Make `form_type` Match #6846

Open

deeleeramone wants to merge 3 commits into develop from bugfix/sec-company-filings

+6 −13

Contributor

deeleeramone commented Oct 22, 2024

Why?:
- When attempting to filter for Form 4 resulted in other types of forms with '4' in it.
- Unexpected nan values from empty dates.
What?:
- Filters the form_type using "isin" instead of "contains".
- Moves nan replace to the bottom, immediately before the output.
Impact:
- Improved precision in the results.
- Bug fix.
Testing Done:

# Multiple forms with '4' in it
obb.equity.fundamental.filings("CRM", form_type='4,144,S-4', limit=0, provider="sec")

# Just Form 4
obb.equity.fundamental.filings("CRM", form_type='4', limit=0, provider="sec").to_df().report_type.unique()

deeleeramone added 3 commits

October 22, 2024 15:45


purge nan values and put word boundaries on form_type filter.

1ccf00e


just replace nan at the output

47a6f1e


use isin instead

ce258d8

deeleeramone added bug platform v4 labels

deeleeramone requested a review from IgorWounds

October 22, 2024 23:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment