Skip to content

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Aug 29, 2025

creating a new one to repalce https://github.com/OpenAPITools/openapi-generator/blob/master/.github/workflows/samples-dart.yaml which doesn't seem to be maintained/catching errors as expected

fyi @jaumard (2018/09) @josh-burton (2019/12) @amondnet (2019/12) @sbu-WBT (2020/12) @kuhnroyal (2020/12) @agilob (2020/12) @ahmednfwela (2021/08)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328 wing328 changed the title Add new workflow to test dart Add new workflow to test dart samples Aug 29, 2025
@wing328 wing328 changed the title Add new workflow to test dart samples Add new workflow to test dart-dio samples Aug 29, 2025
@wing328 wing328 added this to the 7.16.0 milestone Aug 29, 2025
@wing328 wing328 marked this pull request as ready for review August 29, 2025 08:44
@wing328 wing328 merged commit 443fd76 into master Aug 30, 2025
29 checks passed
@wing328 wing328 deleted the dart-ci branch August 30, 2025 13:33
Goopher pushed a commit to Goopher/openapi-generator that referenced this pull request Sep 9, 2025
* add new workflow to test dart

* fix

* fix

* fix versions

* newer version

* newer version

* newer version

* newer version

* newer version

* setup flutter

* update

* update

* fix path

* trigger build failure

* Revert "trigger build failure"

This reverts commit 36b688d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant