Skip to content

[BUG][Kotlin] fix: kotlin code generator should sanitize enum values according to convention #21459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 25, 2025
Merged

[BUG][Kotlin] fix: kotlin code generator should sanitize enum values according to convention #21459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3b47915
fix kotlin code generator should sanitize enum values according to co…
msnteixeira Jun 24, 2025
51a55bc
update samples
msnteixeira Jun 24, 2025
40cbdb3
Revert "update samples"
msnteixeira Jun 25, 2025
ea23f55
Merge branch 'OpenAPITools:master' into master
msnteixeira Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...api-generator/src/main/java/org/openapitools/codegen/languages/AbstractKotlinCodegen.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -572,7 +572,7 @@ public String toEnumVarName(String value, String datatype) {
if (value.isEmpty()) {
modified = "EMPTY";
} else {
modified = value;
modified = value.replaceAll("-", "_");
modified = sanitizeKotlinSpecificNames(modified);
}

Expand Down
5 changes: 5 additions & 0 deletions ...pi-generator/src/test/java/org/openapitools/codegen/kotlin/AbstractKotlinCodegenTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ public void camlCaseEnumConverter() {
codegen.setEnumPropertyNaming(camelCase.name());
assertEquals(codegen.toEnumVarName("long Name", null), "longName");
assertEquals(codegen.toEnumVarName("1long Name", null), "_1longName");
assertEquals(codegen.toEnumVarName("long-Name", null), "longName");
assertEquals(codegen.toEnumVarName("not1long Name", null), "not1longName");
}

Expand All @@ -56,6 +57,7 @@ public void uppercaseEnumConverter() {
codegen.setEnumPropertyNaming(UPPERCASE.name());
assertEquals(codegen.toEnumVarName("long Name", null), "LONG_NAME");
assertEquals(codegen.toEnumVarName("1long Name", null), "_1LONG_NAME");
assertEquals(codegen.toEnumVarName("long-Name", null), "LONG_NAME");
assertEquals(codegen.toEnumVarName("not1long Name", null), "NOT1LONG_NAME");
}

Expand All @@ -64,6 +66,7 @@ public void snake_caseEnumConverter() {
codegen.setEnumPropertyNaming(snake_case.name());
assertEquals(codegen.toEnumVarName("long Name", null), "long_name");
assertEquals(codegen.toEnumVarName("1long Name", null), "_1long_name");
assertEquals(codegen.toEnumVarName("long-Name", null), "long_name");
assertEquals(codegen.toEnumVarName("not1long Name", null), "not1long_name");
}

Expand All @@ -72,6 +75,7 @@ public void originalEnumConverter() {
codegen.setEnumPropertyNaming(original.name());
assertEquals(codegen.toEnumVarName("long Name", null), "long_Name");
assertEquals(codegen.toEnumVarName("1long Name", null), "_1long_Name");
assertEquals(codegen.toEnumVarName("long-Name", null), "longMinusName");
assertEquals(codegen.toEnumVarName("not1long Name", null), "not1long_Name");
assertEquals(codegen.toEnumVarName("data/*", null), "dataSlashStar");
}
Expand All @@ -81,6 +85,7 @@ public void pascalCaseEnumConverter() {
codegen.setEnumPropertyNaming(PascalCase.name());
assertEquals(codegen.toEnumVarName("long Name", null), "LongName");
assertEquals(codegen.toEnumVarName("1long Name", null), "_1longName");
assertEquals(codegen.toEnumVarName("long-Name", null), "LongName");
assertEquals(codegen.toEnumVarName("not1long Name", null), "Not1longName");
}

Expand Down
Loading