Skip to content

feat(test-tools): device compatibility system with expected overrides#674

Draft
wabicai wants to merge 7 commits intoonekeyfrom
feat/device-compatibility-system
Draft

feat(test-tools): device compatibility system with expected overrides#674
wabicai wants to merge 7 commits intoonekeyfrom
feat/device-compatibility-system

Conversation

@wabicai
Copy link
Member

@wabicai wabicai commented Feb 8, 2026

Summary

  • Extend DevicePlugin interface with ignoreMethodParams and expectedOverrides to support param-level filtering and device-specific expected results
  • Integrate compatibility checks into Blind Signature Security Test (generateRequestParams, processRequest, processResponse)
  • Add device-specific expected result display in ResultView

Device Plugin Updates

Classic

  • ignoreMethod: alephium, scdo, ton, neo, benfen, btcSignPsbt, aptosSignInMessage, aptosSignTransaction (USB error), tronSignMessage, deviceRebootToBoardloader
  • ignoreMethodParams: EIP-7702 (authorizationList) not supported
  • expectedOverrides: stellar/nem wrong coin type succeeds (warning only), sol correct coin type 501 returns Invalid params

Classic 1S / Classic Pure

  • ignoreMethod: dnxGetAddress, dnxSignTransaction (performance limitation)
  • expectedOverrides: stellar/nem wrong coin type succeeds (safety checks off), sol correct coin type 501 returns Invalid params

Known Issues (TODO)

Device Method Issue
Classic aptosSignTransaction USB transfer error, likely firmware bug
Classic / 1S / Pure solSignTransaction Returns Invalid params with correct coin type 501

Test plan

  • Run Blind Signature Security Test on Classic - verify skipped methods and expected overrides
  • Run Blind Signature Security Test on Classic 1S - verify dnx skip and expected overrides
  • Run Blind Signature Security Test on Classic Pure - verify same behavior as Classic 1S
  • Run Blind Signature Security Test on Touch/Pro/Mini - verify no regressions

🤖 Generated with Claude Code

…ides

- Extend DevicePlugin interface with ignoreMethodParams and expectedOverrides
- Add param-level compatibility checks (e.g. EIP-7702 authorizationList)
- Add expected result overrides for device behavioral differences
- Update Classic plugin: unsupported methods, param filters, expected overrides
- Update Classic 1S plugin: DNX methods, stellar/nem/sol overrides
- Sync Classic Pure plugin with Classic 1S configuration
- Integrate compatibility checks into Blind Signature Security Test
- Add device-specific expected display in ResultView
- Add device method support documentation

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@revan-zhang
Copy link
Contributor

revan-zhang commented Feb 8, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants