Skip to content

feat: highlight address in send confirm page#10368

Draft
originalix wants to merge 1 commit intoxfrom
feat/highlight-address-in-send-confirm
Draft

feat: highlight address in send confirm page#10368
originalix wants to merge 1 commit intoxfrom
feat/highlight-address-in-send-confirm

Conversation

@originalix
Copy link
Collaborator

@originalix originalix commented Feb 26, 2026

Summary

  • Add variant prop to HighlightAddress component (grouped for receive page, inline for send confirm)
  • Add highlightAddress field to IDisplayComponentAddress interface
  • Highlight all non-FROM address components (TO, contract) in send confirm with $textInteractive color
  • Use mono font ($monoMedium) for all address display in send confirm

Changed Files

  • HighlightAddress/index.tsx — new inline variant (no char grouping, just color highlight)
  • signatureConfirm.tshighlightAddress?: boolean on address interface
  • ServiceSignatureConfirm.ts — post-process display components to mark non-FROM addresses
  • Address.tsx — render HighlightAddress when highlightAddress is true, mono font for all addresses

Test plan

  • Send confirm (regular transfer): TO address highlighted, FROM not
  • Send confirm (self-transfer): TO highlighted, FROM not
  • Send confirm (contract interaction): contract address highlighted
  • Receive page: HighlightAddress still works as before (grouped + mono)

Open with Devin

@revan-zhang
Copy link
Contributor

revan-zhang commented Feb 26, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8e376d3e66

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 4 additional findings.

Open in Devin Review

@originalix originalix marked this pull request as draft February 26, 2026 15:05
auto-merge was automatically disabled February 26, 2026 15:05

Pull request was converted to draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants