feat(market): support perps type banner with conditional detail rende…#10337
Open
xinlongwang-code wants to merge 6 commits intoOneKeyHQ:xfrom
Open
feat(market): support perps type banner with conditional detail rende…#10337xinlongwang-code wants to merge 6 commits intoOneKeyHQ:xfrom
xinlongwang-code wants to merge 6 commits intoOneKeyHQ:xfrom
Conversation
…ring Add EMarketBannerType enum (ticker/perps) and wire it through route params so banner detail page renders either spot token list or perps token table (with leverage badges, funding rate, OI columns) based on banner type. Add fetchMarketBannerPerpsTokenList API method for the new /v2/market/banner/perps-token-list/:id endpoint. Extract perps column hooks into reusable usePerpsColumns for shared use.
xinlongwang-code
requested review from
ezailWang,
huhuanming,
originalix,
revan-zhang and
sidmorizon
as code owners
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
- i18n: replace hardcoded English column titles in mobile perps columns with intl.formatMessage - security: add encodeURIComponent to tokenListId URL path params to prevent path traversal - perf: add 30s pollingInterval for perps banner detail data freshness - perf: add extraData prop to perps Table for proper re-render on data updates
Move inline PerpsTokenListSection component to its own file under MarketBannerDetail directory, including perps data fetching logic, to keep MarketBannerDetail focused on page layout.
limichange
force-pushed
the
feat/market-perps-banner
branch
from
9a07557 to
d96656d
Compare
originalix
approved these changes
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ring
Add EMarketBannerType enum (ticker/perps) and wire it through route params so banner detail page renders either spot token list or perps token table (with leverage badges, funding rate, OI columns) based on banner type. Add fetchMarketBannerPerpsTokenList API method for the new /v2/market/banner/perps-token-list/:id endpoint. Extract perps column hooks into reusable usePerpsColumns for shared use.