fix(ios): guard against UIViewControllerHierarchyInconsistency in all navigation hosts

[huhuanming]

Summary

• Extends the UIHostingController skip guard from RNSScreenStack.mm to all reactAddControllerToClosestParent: call sites in react-native-screens
• Fixes a fatal iOS crash (654 events, 127 users) where RNSNavigationController gets added as a child of UIHostingController, which SwiftUI then re-parents during layout updates, causing UIViewControllerHierarchyInconsistency
• The previous patch (decd5eeead) only covered RNSScreenStack.mm but missed three other files: RNSBottomTabsHostComponentView.mm, RNSSplitViewHostComponentView.mm, and RNSStackHostComponentView.mm

Root Cause

When using react-native-bottom-tabs (SwiftUI TabView), the tab content is wrapped in UIHostingController. SwiftUI internally re-parents UIHostingController instances during layout updates. If react-native-screens attaches a navigation controller as a child of UIHostingController, the parent reference becomes stale after SwiftUI re-parents it, triggering UIViewControllerHierarchyInconsistency.

Changes

patches/react-native-screens+4.23.0.patch -- Added UIHostingController skip guard to:

• RNSBottomTabsHostComponentView.mm (most likely crash source -- bottom tabs host)
• RNSSplitViewHostComponentView.mm (split view host)
• RNSStackHostComponentView.mm (stack host)

The guard checks if the candidate parent view controller's class name contains "UIHostingController" and, if so, continues walking up the view hierarchy to find a stable non-SwiftUI parent.

Test plan

• Verify iOS app launches without crash on devices running iOS 17+
• Navigate between bottom tabs multiple times rapidly
• Open and close modal screens from different tabs
• Verify navigation stack push/pop works correctly within tabs
• Monitor Sentry for REACT-NATIVE-3YZ after deployment

Fixes REACT-NATIVE-3YZ

---

[revan-zhang]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scanner	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues
✅	Licenses	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[huhuanming]

Code Review Summary

Reviewed Items

1. Guard logic is correct — UIHostingController skip pattern is consistent across all 3 new files and the existing RNSScreenStack.mm
2. No navigation regression risk — The guard only activates when UIHostingController is in the hierarchy; normal code path is unchanged
3. Loop advancement is correct — continue with parentView = parentView.reactSuperview correctly walks up the hierarchy

Review Findings

Finding 1: RNSScreenContainer.mm not covered (82% confidence)
The Paper architecture path inherits from UIView+React without the guard. If only Fabric is used in production, this is not an issue.

Finding 2: Trailing whitespace in RNSScreenStack.mm hunk
Byte-level inspection confirmed no trailing whitespace exists in the actual patch file. The visual artifact was from GitHub's diff rendering. No fix needed.

Resolution

✅ No changes needed — Patch is clean. The RNSScreenContainer.mm gap is acceptable since we use Fabric (New Architecture) in production.

[devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 4 additional findings.

[huhuanming]

Merge conflict resolved — kept both iOS UIHostingController skip logic and Android FragmentManager reentrant transaction guard in the patch file.