Disable Travel Behavior Studies Feature #1241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amr Hossam <[email protected]>
Signed-off-by: Amr Hossam <[email protected]>
Signed-off-by: Amr Hossam <[email protected]>
Signed-off-by: Amr Hossam <[email protected]>
aaronbrethorst
requested changes
Sep 5, 2024
| @@ -77,6 +77,11 @@ | |||
| import java.util.ArrayList; | |||
| import java.util.List; | |||
|
|
|||
| /** | |||
| * This feature has been disabled due to issues related to ticket #1240. | |||
Signed-off-by: Amr Hossam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1240
Key Changes
Disabled Travel Behavior Functionality (No longer using
ACTIVITY_RECOGNITION)Commented Out Public Functions in
TravelBehaviourManagerTo make restoring the feature easier in the future, public functions have been commented instead of fully removing them. This avoids the need to edit multiple parts of the code.
Removed
ACTIVITY_RECOGNITIONPermission fromAndroidManifest.xmlSince the travel behavior functionality is no longer in use, the related permission has been removed from the manifest file.
Removed Preferences Related to the Travel Behavior Study
Cleaned up preferences and configurations that were associated with the travel behavior study feature.
Apply the
AndroidStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
gradlew connectedObaGoogleDebugAndroidTestto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them for the initial submission of the pull