feat: Integrate Recent Stops Data into External Surveys #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added functionality to include recent stop information in external survey forms. Signed-off-by: Amr Hossam <[email protected]>
aaronbrethorst
requested changes
Sep 2, 2024
| object RecentStopsManager { | ||
|
|
||
| // Maximum stops count to save | ||
| private var MAX_STOP_COUNT = 5 |
|
|
||
| withContext(Dispatchers.IO) { | ||
| val existingRegion = regionDao.getRegionByID(regionId) | ||
| if (existingRegion == null) { |
There was a problem hiding this comment.
what happens when properties of a region change? (e.g. the server URL changes or the support email address changes?)
There was a problem hiding this comment.
I don't save any of them I only save the region ID, currently, this table is customized for the survey feature only and can be extended in the future.
onebusaway-android/src/main/java/org/onebusaway/android/database/recentStops/dao/RegionDao.kt
Outdated
Show resolved
Hide resolved
| @@ -231,6 +232,7 @@ public IntentBuilder(Context context, String stopId) { | |||
| public IntentBuilder(Context context, ObaStop stop, HashMap<String, ObaRoute> routes) { | |||
| mIntent = new Intent(context, ArrivalsListFragment.class); | |||
| mIntent.setData(Uri.withAppendedPath(ObaContract.Stops.CONTENT_URI, stop.getId())); | |||
| RecentStopsManager.saveStop(context,stop); | |||
Signed-off-by: Amr Hossam <[email protected]>
Signed-off-by: Amr Hossam <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added functionality to include recent stop information in external survey forms.
Apply the
AndroidStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
gradlew connectedObaGoogleDebugAndroidTestto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them for the initial submission of the pull request. When addressing comments on a pull request, please push a new commit per comment when possible (reviewers will squash and merge using GitHub merge tool)