Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added themed icon support with monochrome icon. #1109

Closed
wants to merge 2 commits into from

Conversation

kungharrison
Copy link
Contributor

Support for themed icons for Android 13+. I kept the monochrome version identical to the original icon, just with added transparency.

Changes:
ic_launcher_monochrome.xml: Modified the original logo svg with transparency using Inkscape
ic_launcher.xml: Added monochrome icon support
ic_launcher_round.xml: Added monochrome icon support

Screenshots:
Default Icon (will still be used if themed icon is turned off or not supported in API < 33)
image
Themed Icon (Red & Day)
image
Themed Icon (Red & Night)
image
Themed Icon in on Device
image

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Apply the AndroidStyle.xml style template to your code in Android Studio.
  • Run the unit tests with gradlew connectedObaGoogleDebugAndroidTest to make sure you didn't break anything
  • If you have multiple commits please combine them into one commit by squashing them for the initial submission of the pull request. When addressing comments on a pull request, please push a new commit per comment when possible (reviewers will squash and merge using GitHub merge tool)

@aaronbrethorst
Copy link
Member

thanks @kungharrison! I'm supposed to be receiving an Android 14 device in the mail soon (USPS lost the first one 🙄, but thankfully the vendor's being cool about it and is supposed to ship me another one tomorrow). I'd like to review this on a device before merging, so it will be a few days, but it's on my radar! Please ping me if you haven't seen this get merged within a week.

@kungharrison
Copy link
Contributor Author

kungharrison commented Jan 31, 2024

@aaronbrethorst Hmm, I'm not sure why it's failing the tests, I ran the tests locally and it worked fine, plus there's really no change in code that should cause all the tests to fail. It seems all the tests are getting skipped, maybe there's a problem with the CI pipeline?
image

@aaronbrethorst
Copy link
Member

"Failing after 360m"

Sounds like something went wrong in the pipeline. I'll try running it again.

@kungharrison
Copy link
Contributor Author

@aaronbrethorst Unfortunately it still seems to not be working. There seems to be an error with the emulator starting up, I see these lines stating the emulator is out of date that weren't happening with my previous pull request.

Current pull request failed test:
image
Past pull request successfully run:
image

Then it seems to start throwing a bunch of errors and never reaches the "Emulator booted." stage, so I think the issue with the tests timing out at 6 hours might have something to do with that?

Current pull request failed test:
image
Past pull request successfully run:
image

@kungharrison
Copy link
Contributor Author

At this point I'm wondering if the tests are failing is because is supported in API level 33+?

@aaronbrethorst
Copy link
Member

@kungharrison hmm, that's an interesting angle to explore. I'll investigate.

@aaronbrethorst
Copy link
Member

I'll merge this in #1118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants