This repository has been archived by the owner on Feb 4, 2022. It is now read-only.
Sharing on iOS #233
Open
Sharing on iOS #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3fa0c55.
|
In the current state, sharing on iOS works fine from other apps directly to Openbook. There probably are some edge cases when it doesn't work and proper error handling is missing in some places as well. |
|
Hi Sophie! Tried sharing from the gallery to Openbook and nothing happened, perhaps this is one of those edge cases? It allows to add text as well over there 🤔 |
|
Hi Joel,
thanks for the info. I'll investigate this when I'm home. Can you tell me which version of iOS you tested this on? It works on iOS 12.1 for me.
|
|
Hi Sophie!
Sure thing, no hurries. I’m on 12.1.4.
Should the behavior be the Openbook app opening up with the selected image
and text ?
Good weekend !
…On Sat, 6 Apr 2019 at 16:51, Sophie Tauchert ***@***.***> wrote:
Hi Joel,
thanks for the info. I'll investigate this when I'm home. Can you tell me
which version of iOS you tested this on? It works on iOS 12.1 for me.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#233 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMJb5VV4UYc0BYwGsv_3koLTNZxWi4k6ks5veLRmgaJpZM4cflfY>
.
|
|
The intended behaviour is that the Openbook app opens with the selected image and text when you tap "Post" in the share pop-up.
|
|
@lifenautjoe is this ready to go? was just looking at all the Open PRs |
|
@uiboy there's still a problem with this as it works perfectly fine in the iOS simulator, but when @lifenautjoe tried it on a physical device, nothing happened. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements sharing images on iOS directly to Openbook.