Change variable declaration to alias in generate-env.js
#15018
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When declared as a constant, the envvar can't be used in string concatenation (string interpolation). For example, say you have an authenticated endpoint. When envvars are constants, you can't use it when creating an `alias`. If this PR is merged, this fixes the issue and allows envvars to be used in string interpolation scenarios. fixes OfficeDev#15017
andrewconnell
requested review from
Alive-Fish,
HuihuiWu-Microsoft,
Sherylueen,
llhmm01,
qinqingxu,
qinzhouxu,
tecton,
wh-alice and
yuqizhou77
as code owners
Contributor
Author
|
fyi @sebastienlevert |
sebastienlevert
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When declared as a constant, the envvar can't be used in string concatenation (string interpolation). For example, say you have an authenticated endpoint. When envvars are constants, you can't use it when creating an
alias.If this PR is merged, this fixes the issue and allows envvars to be used in string interpolation scenarios. See #15017 for the issue that this fixes with examples
fixes #15017