Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update section Differences with Ethereum #689

Merged
merged 8 commits into from
Oct 23, 2023
Merged

Update section Differences with Ethereum #689

merged 8 commits into from
Oct 23, 2023

Conversation

TucksonDev
Copy link
Contributor

@TucksonDev TucksonDev commented Oct 17, 2023 •
edited
Loading

This PR cleans and updates the contents of the sections "Differences between Arbitrum and Ethereum" and "Migrate to Arbitrum":

  • It creates an Overview of all the sections that describe differences between Arbitrum and Ethereum
  • It adds new content around timestamps to the "Block numbers and time" page
  • It formats the information in tables rather than lists
  • It moves the "RPC methods" section to its own page
  • It removes the page "Migrate from Classic to Nitro" (one relevant FAQ was created in the process, but not yet added to this PR)
  • It redirects all previous URLs to the new URLs

A few FAQs need to be updated, which will happen after this PR is merged

Preview

@cla-bot cla-bot bot added the s label Oct 17, 2023
@vercel
Copy link

vercel bot commented Oct 17, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nitro-docs ✅ Ready (Inspect) Visit Preview Oct 23, 2023 5:56pm

@TucksonDev
Copy link
Contributor Author

@mahsamoosavi , @DZGoldman , if you have a minute, could you verify that the information in the Block timestamps section is correct? 🙏

DZGoldman
DZGoldman suggested changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@DZGoldman DZGoldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - left comments on a handful of little things

@TucksonDev
Copy link
Contributor Author

Thanks very much for the review @DZGoldman ! 🙏 Added your suggestions and replied to some of the comments for further discussion (if needed).

symbolpunk
symbolpunk approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@symbolpunk symbolpunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bamf

@symbolpunk symbolpunk merged commit 65b4a24 into master Oct 23, 2023
2 checks passed
@symbolpunk symbolpunk deleted the ethereum-vs-arbitrum branch October 23, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@symbolpunk symbolpunk symbolpunk approved these changes

@DZGoldman DZGoldman DZGoldman approved these changes

@mahsamoosavi mahsamoosavi Awaiting requested review from mahsamoosavi

Assignees
No one assigned
Labels
s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TucksonDev @DZGoldman @symbolpunk