Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid approach initialisation maps #34

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

michaeldenes
Copy link
Member

@michaeldenes michaeldenes commented May 27, 2024

This is a PR that changes the way we initialise particles, rather than one particle at the T-point of a grid cell, we will initialise n particles randomly within a grid cell.

  • Test grid-cell selection in the create_release_maps.py file is working as expected
  • Update the create_particleset_from_map() function in constructors to use the grid cells

Point 2 above is non-trivial, as we want to randomly distribute particle across the grid cell. Trivial for a rectilinear grid, but non-trivial for our curvilinear grid. Possible approach is to perform a rotation (like the Jacobian approach in the interpolation scheme?)

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 15.33%. Comparing base (fe32c0b) to head (d1d20d4).
Report is 106 commits behind head on main.

Files Patch % Lines
plasticparcels/constructors.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
- Coverage   15.43%   15.33%   -0.10%     
==========================================
  Files           6        6              
  Lines         473      476       +3     
==========================================
  Hits           73       73              
- Misses        400      403       +3     
Flag Coverage Δ
unit-tests 15.33% <0.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants