Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default value of particlefile chunks to length of pset #1788

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Update default value of particlefile chunks to length of pset #1788

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0333dff
Update default value of particlefile chunks to length of pset
erikvansebille Dec 5, 2024
7542e4c
Merge branch 'master' into update_pfile_chunks
erikvansebille Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion parcels/particlefile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@

if self.create_new_zarrfile:
if self.chunks is None:
self._chunks = (len(ids), 1)
self._chunks = (len(pset), 1)

Check warning on line 307 in parcels/particlefile.py

View check run for this annotation

Codecov / codecov/patch

parcels/particlefile.py#L307 

Added line #L307 was not covered by tests
if pset._repeatpclass is not None and self.chunks[0] < 1e4: # type: ignore[index]
warnings.warn(
f"ParticleFile chunks are set to {self.chunks}, but this may lead to "
Expand Down
Loading