Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make filefieldbuffer.py private #1774

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Make filefieldbuffer.py private #1774

wants to merge 2 commits into from
+881 −858

Conversation

VeckoTheGecko
Copy link
Contributor

@VeckoTheGecko VeckoTheGecko commented Nov 25, 2024 •
edited
Loading

Fixes #1773

(easier to review by looking at commit diffs)

@VeckoTheGecko
Copy link
Contributor Author

Uhh. Looks like we have DaskFileBuffer.add_to_dimension_name_map_global() and DaskFileBuffer.add_to_dimension_name_map() which are flagged with [externally callable]

Marking as draft while I have a think

@VeckoTheGecko VeckoTheGecko marked this pull request as draft November 25, 2024 17:24
@VeckoTheGecko VeckoTheGecko removed the request for review from erikvansebille November 25, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Parcels development
Status: Backlog
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make filefieldbuffer.py private
1 participant
@VeckoTheGecko