Add Unstructured Grid class #1751
Draft
+1,176
−453
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properties and procedures that are common to unstructured grids and structured grids are defined in the
BaseGrid
class. This includeslon
,lat
,time
,time_origin
, andmesh
properties.The
Grid
class is now defined as a type extension ofBaseGrid
. This configuration is compatible with the previous commit of Parcels (all existing tests pass). The_zonal_periodic
,_zonal_halo
,_meridional_halo
, and_lat_flipped
properties are seen as attributes specific to the structured gridGrid
class.The
UGrid
class is defined as a type extension of theBaseGrid
. This child class adds theface_node_connectivity
property that relates vertices to the 2-D lateral grid faces. The lon and lat attributes refer to thenode_lon
andnode_lat
that are defined in theuxarray.Grid
structure; these are the corner node vertices. Note that there are other possible nodes, including the edge vertices (centers of the edges), andface_vertices
that define the element centroids; these are currently not defined.