Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding explicit explanation how to add tracers in FieldSet.from_nemo() #1702

Merged
merged 4 commits into from
Sep 25, 2024

Conversation

erikvansebille
Copy link
Member

Fixes #1700

Copy link
Contributor

@VeckoTheGecko VeckoTheGecko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any usecases then for providing T-points to the Nemo constructor?

Do you think we should also add additional validation to the from_nemo function? Maybe if there's no usecase for T-points, we can warn if they provide >2 unique dimensions for grids.

docs/examples/tutorial_nemo_3D.ipynb Outdated Show resolved Hide resolved
@erikvansebille
Copy link
Member Author

Do you think we should also add additional validation to the from_nemo function? Maybe if there's no usecase for T-points, we can warn if they provide >2 unique dimensions for grids.

Well, users may want to add wind or stokes drift from other models, that would then be on a different grid. So I don't think we can enforce only 1 Grid when the velocities are from_nemo

@erikvansebille erikvansebille merged commit bd6a09a into master Sep 25, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Adding information on how to define dimensions for tracers on C-grid
3 participants