Skip to content

Commit

Permalink
OXDEV-7557 Fix missing and incorrect typehints
Browse files Browse the repository at this point in the history
Signed-off-by: Anton Fedurtsya <[email protected]>
  • Loading branch information
Sieg committed Nov 15, 2023
1 parent 04ea2f1 commit f8a7445
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,13 @@ public function __construct(
) {
}

protected function throwGetterNotFoundException(string $typeString)
protected function throwGetterNotFoundException(string $typeString): void
{
$aOrAn = (preg_match('/^[aeiou]/i', $typeString)) ? 'an' : 'a';
throw new NotFound("The queried name couldn't be found as $aOrAn $typeString configuration");
}

protected function throwSetterNotFoundException(string $typeString, string $name)
protected function throwSetterNotFoundException(string $typeString, string $name): void
{
throw new NotFound('The ' . $typeString . ' setting "' . $name . '" doesn\'t exist');
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public function getCollection(ID $name): array;
public function getAssocCollection(ID $name): array;

/**
* @return array<string, FieldType>
* @return array<string, string>
*/
public function getSettingsList(): array;
}
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public function getCollection(ID $name, string $themeId): array;
public function getAssocCollection(ID $name, string $themeId): array;

/**
* @return array<string, FieldType>
* @return array<string, string>
*/
public function getSettingsList(string $themeId): array;

Expand Down

0 comments on commit f8a7445

Please sign in to comment.