OXDEV-7713: Remove HideIfUnauthorized annotations in controllers

OXID-eSales · Jan 16, 2024 · b6fc57c · b6fc57c
1 parent 4af43af
commit b6fc57c
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 44 deletions.
diff --git a/src/Module/Controller/ModuleSettingController.php b/src/Module/Controller/ModuleSettingController.php
@@ -15,7 +15,6 @@
 use OxidEsales\GraphQL\ConfigurationAccess\Shared\DataType\IntegerSetting;
 use OxidEsales\GraphQL\ConfigurationAccess\Shared\DataType\SettingType;
 use OxidEsales\GraphQL\ConfigurationAccess\Shared\DataType\StringSetting;
-use TheCodingMachine\GraphQLite\Annotations\HideIfUnauthorized;
 use TheCodingMachine\GraphQLite\Annotations\Logged;
 use TheCodingMachine\GraphQLite\Annotations\Mutation;
 use TheCodingMachine\GraphQLite\Annotations\Query;
@@ -33,7 +32,6 @@ public function __construct(
 
     #[Query]
     #[Logged]
-    #[HideIfUnauthorized]
     #[Right('CHANGE_CONFIGURATION')]
     public function moduleSettingBoolean(string $name, string $moduleId): BooleanSetting
     {
@@ -42,7 +40,6 @@ public function moduleSettingBoolean(string $name, string $moduleId): BooleanSet
 
     #[Query]
     #[Logged]
-    #[HideIfUnauthorized]
     #[Right('CHANGE_CONFIGURATION')]
     public function moduleSettingCollection(string $name, string $moduleId): StringSetting
     {
@@ -51,7 +48,6 @@ public function moduleSettingCollection(string $name, string $moduleId): StringS
 
     #[Query]
     #[Logged]
-    #[HideIfUnauthorized]
     #[Right('CHANGE_CONFIGURATION')]
     public function moduleSettingFloat(string $name, string $moduleId): FloatSetting
     {
@@ -60,7 +56,6 @@ public function moduleSettingFloat(string $name, string $moduleId): FloatSetting
 
     #[Query]
     #[Logged]
-    #[HideIfUnauthorized]
     #[Right('CHANGE_CONFIGURATION')]
     public function moduleSettingInteger(string $name, string $moduleId): IntegerSetting
     {
@@ -69,7 +64,6 @@ public function moduleSettingInteger(string $name, string $moduleId): IntegerSet
 
     #[Query]
     #[Logged]
-    #[HideIfUnauthorized]
     #[Right('CHANGE_CONFIGURATION')]
     public function moduleSettingString(string $name, string $moduleId): StringSetting
     {
@@ -81,7 +75,6 @@ public function moduleSettingString(string $name, string $moduleId): StringSetti
      */
     #[Query]
     #[Logged]
-    #[HideIfUnauthorized]
     #[Right('CHANGE_CONFIGURATION')]
     public function moduleSettings(string $moduleId): array
     {
@@ -90,7 +83,6 @@ public function moduleSettings(string $moduleId): array
 
     #[Mutation]
     #[Logged]
-    #[HideIfUnauthorized]
     #[Right('CHANGE_CONFIGURATION')]
     public function moduleSettingBooleanChange(string $name, bool $value, string $moduleId): BooleanSetting
     {
@@ -99,7 +91,6 @@ public function moduleSettingBooleanChange(string $name, bool $value, string $mo
 
     #[Mutation]
     #[Logged]
-    #[HideIfUnauthorized]
     #[Right('CHANGE_CONFIGURATION')]
     public function moduleSettingCollectionChange(string $name, string $value, string $moduleId): StringSetting
     {
@@ -108,7 +99,6 @@ public function moduleSettingCollectionChange(string $name, string $value, strin
 
     #[Mutation]
     #[Logged]
-    #[HideIfUnauthorized]
     #[Right('CHANGE_CONFIGURATION')]
     public function moduleSettingFloatChange(string $name, float $value, string $moduleId): FloatSetting
     {
@@ -117,7 +107,6 @@ public function moduleSettingFloatChange(string $name, float $value, string $mod
 
     #[Mutation]
     #[Logged]
-    #[HideIfUnauthorized]
     #[Right('CHANGE_CONFIGURATION')]
     public function moduleSettingIntegerChange(string $name, int $value, string $moduleId): IntegerSetting
     {
@@ -126,7 +115,6 @@ public function moduleSettingIntegerChange(string $name, int $value, string $mod
 
     #[Mutation]
     #[Logged]
-    #[HideIfUnauthorized]
     #[Right('CHANGE_CONFIGURATION')]
     public function moduleSettingStringChange(string $name, string $value, string $moduleId): StringSetting
     {

diff --git a/src/Shop/Controller/ShopSettingController.php b/src/Shop/Controller/ShopSettingController.php
@@ -15,7 +15,6 @@
 use OxidEsales\GraphQL\ConfigurationAccess\Shared\DataType\SettingType;
 use OxidEsales\GraphQL\ConfigurationAccess\Shared\DataType\StringSetting;
 use OxidEsales\GraphQL\ConfigurationAccess\Shop\Service\ShopSettingServiceInterface;
-use TheCodingMachine\GraphQLite\Annotations\HideIfUnauthorized;
 use TheCodingMachine\GraphQLite\Annotations\Logged;
 use TheCodingMachine\GraphQLite\Annotations\Mutation;
 use TheCodingMachine\GraphQLite\Annotations\Query;
@@ -33,7 +32,6 @@ public function __construct(
 
     #[Query]
     #[Logged]
-    #[HideIfUnauthorized]
     #[Right('CHANGE_CONFIGURATION')]
     public function shopSettingAssocCollection(string $name): StringSetting
     {
@@ -42,7 +40,6 @@ public function shopSettingAssocCollection(string $name): StringSetting
 
     #[Query]
     #[Logged]
-    #[HideIfUnauthorized]
     #[Right('CHANGE_CONFIGURATION')]
     public function shopSettingBoolean(string $name): BooleanSetting
     {
@@ -51,7 +48,6 @@ public function shopSettingBoolean(string $name): BooleanSetting
 
     #[Query]
     #[Logged]
-    #[HideIfUnauthorized]
     #[Right('CHANGE_CONFIGURATION')]
     public function shopSettingCollection(string $name): StringSetting
     {
@@ -60,7 +56,6 @@ public function shopSettingCollection(string $name): StringSetting
 
     #[Query]
     #[Logged]
-    #[HideIfUnauthorized]
     #[Right('CHANGE_CONFIGURATION')]
     public function shopSettingFloat(string $name): FloatSetting
     {
@@ -69,7 +64,6 @@ public function shopSettingFloat(string $name): FloatSetting
 
     #[Query]
     #[Logged]
-    #[HideIfUnauthorized]
     #[Right('CHANGE_CONFIGURATION')]
     public function shopSettingInteger(string $name): IntegerSetting
     {
@@ -78,7 +72,6 @@ public function shopSettingInteger(string $name): IntegerSetting
 
     #[Query]
     #[Logged]
-    #[HideIfUnauthorized]
     #[Right('CHANGE_CONFIGURATION')]
     public function shopSettingSelect(string $name): StringSetting
     {
@@ -87,7 +80,6 @@ public function shopSettingSelect(string $name): StringSetting
 
     #[Query]
     #[Logged]
-    #[HideIfUnauthorized]
     #[Right('CHANGE_CONFIGURATION')]
     public function shopSettingString(string $name): StringSetting
     {
@@ -99,7 +91,6 @@ public function shopSettingString(string $name): StringSetting
      */
     #[Query]
     #[Logged]
-    #[HideIfUnauthorized]
     #[Right('CHANGE_CONFIGURATION')]
     public function shopSettings(): array
     {
@@ -108,7 +99,6 @@ public function shopSettings(): array
 
     #[Mutation]
     #[Logged]
-    #[HideIfUnauthorized]
     #[Right('CHANGE_CONFIGURATION')]
     public function shopSettingAssocCollectionChange(string $name, string $value): StringSetting
     {
@@ -117,7 +107,6 @@ public function shopSettingAssocCollectionChange(string $name, string $value): S
 
     #[Mutation]
     #[Logged]
-    #[HideIfUnauthorized]
     #[Right('CHANGE_CONFIGURATION')]
     public function shopSettingBooleanChange(string $name, bool $value): BooleanSetting
     {
@@ -126,7 +115,6 @@ public function shopSettingBooleanChange(string $name, bool $value): BooleanSett
 
     #[Mutation]
     #[Logged]
-    #[HideIfUnauthorized]
     #[Right('CHANGE_CONFIGURATION')]
     public function shopSettingCollectionChange(string $name, string $value): StringSetting
     {
@@ -135,7 +123,6 @@ public function shopSettingCollectionChange(string $name, string $value): String
 
     #[Mutation]
     #[Logged]
-    #[HideIfUnauthorized]
     #[Right('CHANGE_CONFIGURATION')]
     public function shopSettingFloatChange(string $name, float $value): FloatSetting
     {
@@ -144,7 +131,6 @@ public function shopSettingFloatChange(string $name, float $value): FloatSetting
 
     #[Mutation]
     #[Logged]
-    #[HideIfUnauthorized]
     #[Right('CHANGE_CONFIGURATION')]
     public function shopSettingIntegerChange(string $name, int $value): IntegerSetting
     {
@@ -153,7 +139,6 @@ public function shopSettingIntegerChange(string $name, int $value): IntegerSetti
 
     #[Mutation]
     #[Logged]
-    #[HideIfUnauthorized]
     #[Right('CHANGE_CONFIGURATION')]
     public function shopSettingSelectChange(string $name, string $value): StringSetting
     {
@@ -162,7 +147,6 @@ public function shopSettingSelectChange(string $name, string $value): StringSett
 
     #[Mutation]
     #[Logged]
-    #[HideIfUnauthorized]
     #[Right('CHANGE_CONFIGURATION')]
     public function shopSettingStringChange(string $name, string $value): StringSetting
     {

diff --git a/src/Theme/Controller/ThemeSettingController.php b/src/Theme/Controller/ThemeSettingController.php
@@ -15,7 +15,6 @@
 use OxidEsales\GraphQL\ConfigurationAccess\Shared\DataType\SettingType;
 use OxidEsales\GraphQL\ConfigurationAccess\Shared\DataType\StringSetting;
 use OxidEsales\GraphQL\ConfigurationAccess\Theme\Service\ThemeSettingServiceInterface;
-use TheCodingMachine\GraphQLite\Annotations\HideIfUnauthorized;
 use TheCodingMachine\GraphQLite\Annotations\Logged;
 use TheCodingMachine\GraphQLite\Annotations\Mutation;
 use TheCodingMachine\GraphQLite\Annotations\Query;
@@ -33,7 +32,6 @@ public function __construct(
 
     #[Query]
     #[Logged]
-    #[HideIfUnauthorized]
     #[Right('CHANGE_CONFIGURATION')]
     public function themeSettingAssocCollection(string $name, string $themeId): StringSetting
     {
@@ -42,7 +40,6 @@ public function themeSettingAssocCollection(string $name, string $themeId): Stri
 
     #[Query]
     #[Logged]
-    #[HideIfUnauthorized]
     #[Right('CHANGE_CONFIGURATION')]
     public function themeSettingBoolean(string $name, string $themeId): BooleanSetting
     {
@@ -51,7 +48,6 @@ public function themeSettingBoolean(string $name, string $themeId): BooleanSetti
 
     #[Query]
     #[Logged]
-    #[HideIfUnauthorized]
     #[Right('CHANGE_CONFIGURATION')]
     public function themeSettingCollection(string $name, string $themeId): StringSetting
     {
@@ -60,7 +56,6 @@ public function themeSettingCollection(string $name, string $themeId): StringSet
 
     #[Query]
     #[Logged]
-    #[HideIfUnauthorized]
     #[Right('CHANGE_CONFIGURATION')]
     public function themeSettingFloat(string $name, string $themeId): FloatSetting
     {
@@ -69,7 +64,6 @@ public function themeSettingFloat(string $name, string $themeId): FloatSetting
 
     #[Query]
     #[Logged]
-    #[HideIfUnauthorized]
     #[Right('CHANGE_CONFIGURATION')]
     public function themeSettingInteger(string $name, string $themeId): IntegerSetting
     {
@@ -78,7 +72,6 @@ public function themeSettingInteger(string $name, string $themeId): IntegerSetti
 
     #[Query]
     #[Logged]
-    #[HideIfUnauthorized]
     #[Right('CHANGE_CONFIGURATION')]
     public function themeSettingSelect(string $name, string $themeId): StringSetting
     {
@@ -87,7 +80,6 @@ public function themeSettingSelect(string $name, string $themeId): StringSetting
 
     #[Query]
     #[Logged]
-    #[HideIfUnauthorized]
     #[Right('CHANGE_CONFIGURATION')]
     public function themeSettingString(string $name, string $themeId): StringSetting
     {
@@ -99,7 +91,6 @@ public function themeSettingString(string $name, string $themeId): StringSetting
      */
     #[Query]
     #[Logged]
-    #[HideIfUnauthorized]
     #[Right('CHANGE_CONFIGURATION')]
     public function themeSettings(string $themeId): array
     {
@@ -108,7 +99,6 @@ public function themeSettings(string $themeId): array
 
     #[Mutation]
     #[Logged]
-    #[HideIfUnauthorized]
     #[Right('CHANGE_CONFIGURATION')]
     public function themeSettingAssocCollectionChange(string $name, string $value, string $themeId): StringSetting
     {
@@ -117,7 +107,6 @@ public function themeSettingAssocCollectionChange(string $name, string $value, s
 
     #[Mutation]
     #[Logged]
-    #[HideIfUnauthorized]
     #[Right('CHANGE_CONFIGURATION')]
     public function themeSettingBooleanChange(string $name, bool $value, string $themeId): BooleanSetting
     {
@@ -126,7 +115,6 @@ public function themeSettingBooleanChange(string $name, bool $value, string $the
 
     #[Mutation]
     #[Logged]
-    #[HideIfUnauthorized]
     #[Right('CHANGE_CONFIGURATION')]
     public function themeSettingCollectionChange(string $name, string $value, string $themeId): StringSetting
     {
@@ -136,15 +124,13 @@ public function themeSettingCollectionChange(string $name, string $value, string
 
     #[Mutation]
     #[Logged]
-    #[HideIfUnauthorized]
     #[Right('CHANGE_CONFIGURATION')]
     public function themeSettingFloatChange(string $name, float $value, string $themeId): FloatSetting
     {
         return $this->themeSettingService->changeFloatSetting($name, $value, $themeId);
     }
     #[Mutation]
     #[Logged]
-    #[HideIfUnauthorized]
     #[Right('CHANGE_CONFIGURATION')]
     public function themeSettingIntegerChange(string $name, int $value, string $themeId): IntegerSetting
     {
@@ -153,7 +139,6 @@ public function themeSettingIntegerChange(string $name, int $value, string $them
 
     #[Mutation]
     #[Logged]
-    #[HideIfUnauthorized]
     #[Right('CHANGE_CONFIGURATION')]
     public function themeSettingSelectChange(string $name, string $value, string $themeId): StringSetting
     {
@@ -162,7 +147,6 @@ public function themeSettingSelectChange(string $name, string $value, string $th
 
     #[Mutation]
     #[Logged]
-    #[HideIfUnauthorized]
     #[Right('CHANGE_CONFIGURATION')]
     public function themeSettingStringChange(string $name, string $value, string $themeId): StringSetting
     {